Playground: auto-open @rescript/core when loaded #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerschmidt
force-pushed
the
auto-open-rescript-core
branch
from
4e3734e to
412f86c
Compare
ryyppy
reviewed
Nov 1, 2023
| @@ -431,6 +437,7 @@ module Compiler = { | |||
| } | |||
|
|
|||
| Belt.Option.forEach(moduleSystem, moduleSystem => t->setModuleSystem(moduleSystem)->ignore) | |||
| Belt.Option.forEach(config.open_modules, modules => t->setOpenModules(modules)->ignore) | |||
There was a problem hiding this comment.
I guess here one needs to check for compiler bundle version to be V4 as well?
There was a problem hiding this comment.
Did that but at a different spot (see commit).
cknitt
approved these changes
Nov 1, 2023
fhammerschmidt
force-pushed
the
auto-open-rescript-core
branch
from
32cfe99 to
931b9f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths PR depends on rescript-lang/rescript#6446