Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle completion for polyvars without leading # #874

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Dec 18, 2023

Fixes so that you don't need to explicitly type a leading # to get completion when the underlying value is a polyvar.

@zth zth requested a review from cristianoc December 18, 2023 20:20
@zth zth merged commit 95f77e1 into master Dec 19, 2023
5 checks passed
@zth zth deleted the fix-polyvar-name-completion branch December 19, 2023 09:13
@DZakh
Copy link
Contributor

DZakh commented Dec 19, 2023

It works 😍

It's not critical, but maybe it would be nice not to add curly brackets around variants.

image

@zth
Copy link
Collaborator Author

zth commented Dec 19, 2023

@DZakh the curly braces are intentional

@DZakh
Copy link
Contributor

DZakh commented Dec 19, 2023

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants