Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes Related to IMS and Purchase Reconciliation Tool #2998

Merged
merged 13 commits into from
Jan 24, 2025

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Jan 22, 2025

Copy link

Connected to Huly®: IC-3126

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 38.09524% with 39 lines in your changes missing coverage. Please review.

Project coverage is 57.28%. Comparing base (465eced) to head (20f6e44).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
...management_system/gst_invoice_management_system.py 0.00% 28 Missing ⚠️
india_compliance/gst_india/utils/gstr_2/gstr_2b.py 50.00% 4 Missing ⚠️
..._compliance/gst_india/api_classes/taxpayer_base.py 0.00% 2 Missing ⚠️
india_compliance/gst_india/utils/api.py 66.66% 2 Missing ⚠️
.../doctype/gst_invoice_management_system/__init__.py 0.00% 1 Missing ⚠️
...a/doctype/purchase_reconciliation_tool/__init__.py 0.00% 1 Missing ⚠️
india_compliance/gst_india/utils/gstr_2/ims.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2998      +/-   ##
===========================================
- Coverage    57.39%   57.28%   -0.11%     
===========================================
  Files          126      126              
  Lines        12678    12705      +27     
===========================================
+ Hits          7276     7278       +2     
- Misses        5402     5427      +25     
Files with missing lines Coverage Δ
...iance/gst_india/doctype/gstr_action/gstr_action.py 41.66% <ø> (+4.82%) ⬆️
...ndia_compliance/gst_india/utils/gstr_2/__init__.py 55.62% <100.00%> (+0.53%) ⬆️
india_compliance/gst_india/utils/gstr_2/gstr.py 89.85% <100.00%> (+0.30%) ⬆️
india_compliance/gst_india/utils/gstr_2/gstr_2a.py 95.65% <100.00%> (-0.05%) ⬇️
.../doctype/gst_invoice_management_system/__init__.py 31.11% <0.00%> (ø)
...a/doctype/purchase_reconciliation_tool/__init__.py 50.20% <0.00%> (ø)
india_compliance/gst_india/utils/gstr_2/ims.py 73.63% <50.00%> (-0.68%) ⬇️
..._compliance/gst_india/api_classes/taxpayer_base.py 24.36% <0.00%> (-0.21%) ⬇️
india_compliance/gst_india/utils/api.py 87.50% <66.66%> (-12.50%) ⬇️
india_compliance/gst_india/utils/gstr_2/gstr_2b.py 90.78% <50.00%> (-1.42%) ⬇️
... and 1 more

Impacted file tree graph

@Ninad1306 Ninad1306 marked this pull request as draft January 22, 2025 12:27
@Ninad1306 Ninad1306 changed the title fix: Fixes Related to IMS fix: Fixes Related to IMS and Purchase Reconciliation Tool Jan 23, 2025
@Ninad1306 Ninad1306 marked this pull request as ready for review January 23, 2025 12:41
@Ninad1306 Ninad1306 requested a review from vorasmit January 24, 2025 12:01
@vorasmit vorasmit merged commit a3354d4 into resilient-tech:develop Jan 24, 2025
11 checks passed
@Ninad1306 Ninad1306 deleted the ims-fixes branch January 24, 2025 12:28
mergify bot added a commit that referenced this pull request Jan 24, 2025
…tfix/pr-2998

fix: Fixes Related to IMS and Purchase Reconciliation Tool (backport #2998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants