check for new version every 2 weeks

responsively-org · Sep 21, 2024 · a192e05 · a192e05
1 parent 835be54
commit a192e05
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 10 deletions.
diff --git a/desktop-app/src/renderer/components/ToolBar/Menu/index.tsx b/desktop-app/src/renderer/components/ToolBar/Menu/index.tsx
@@ -40,9 +40,9 @@ const Menu = () => {
     <div className="relative mr-2 flex items-center" ref={ref}>
       <Button onClick={handleFlyout} isActive={isMenuFlyoutOpen}>
         <Icon icon="carbon:overflow-menu-vertical" />
-        {notifications?.length > 0 && Boolean(hasNewNotifications) && (
-          <NotificationsBubble />
-        )}
+        {notifications &&
+          notifications?.length > 0 &&
+          Boolean(hasNewNotifications) && <NotificationsBubble />}
       </Button>
       <div style={{ visibility: isMenuFlyoutOpen ? 'visible' : 'hidden' }}>
         <MenuFlyout closeFlyout={onClose} />

diff --git a/desktop-app/src/renderer/components/useCheckVersion/useCheckVersion.tsx b/desktop-app/src/renderer/components/useCheckVersion/useCheckVersion.tsx
@@ -1,5 +1,6 @@
 import { useState, useEffect } from 'react';
 import { gt } from 'semver';
+import useLocalStorage from '../useLocalStorage/useLocalStorage';
 
 const fetchAssets = async () => {
   try {
@@ -30,29 +31,47 @@ const useCheckVersion = () => {
   const [isNewVersionAvailable, setIsNewVersionAvailable] = useState<
     null | boolean
   >(null);
-  const [latestVersion, setLatestVersion] = useState('');
+  const [latestVersion, setLatestVersion] = useLocalStorage<undefined | string>(
+    'latestVersion'
+  );
   const [currentVersion, setCurrentVersion] = useState('');
+  const [lastCheck, setLastCheck] = useLocalStorage<number | undefined>(
+    'lastCheck'
+  );
+  const biWeeklyCheckInMs = 1209600000;
 
   useEffect(() => {
     const checkVersion = async () => {
       const currentVersionResult = await getAppVersion();
-      const latestVersionResult = await fetchAssets();
 
       setCurrentVersion(currentVersionResult);
-      setLatestVersion(latestVersionResult);
 
+      const now = Date.now();
+      if (!latestVersion || !lastCheck || now - lastCheck > biWeeklyCheckInMs) {
+        const latestVersionResult = await fetchAssets();
+        if (latestVersionResult) {
+          setLatestVersion(latestVersionResult);
+          setLastCheck(now);
+        }
+      }
       const isNewVersion =
         currentVersionResult &&
-        latestVersionResult &&
-        gt(latestVersionResult, currentVersionResult);
+        latestVersion &&
+        gt(latestVersion, currentVersionResult);
 
-      setIsNewVersionAvailable(isNewVersion);
+      setIsNewVersionAvailable(Boolean(isNewVersion));
     };
 
     if (isNewVersionAvailable === null) {
       checkVersion();
     }
-  }, [currentVersion, isNewVersionAvailable, latestVersion]);
+  }, [
+    isNewVersionAvailable,
+    lastCheck,
+    latestVersion,
+    setLastCheck,
+    setLatestVersion,
+  ]);
 
   return {
     isNewVersionAvailable,