-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guides & Rulers #1162
Guides & Rulers #1162
Conversation
Adds rules/guides package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such an essential utility and great work implementing it. 🚀
Did review the code and also a round of testing and added the observations as comments on the code.
desktop-app/src/renderer/components/Previewer/Device/Toolbar.tsx
Outdated
Show resolved
Hide resolved
- default empty array - remove default padding - align left px value ofr rulers - updated keyboard shortcut
missing overflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great now!
Is this feature usable? |
It is not live yet, waiting on a related bug to be addressed. It should be out in a week or so. |
✨ Pull Request
📓 Referenced Issue
#1149 Adds persistent guides and rulers
ℹ️ About the PR
🖼️ Testing Scenarios / Screenshots