Skip to content

Commit

Permalink
Bugfixes.
Browse files Browse the repository at this point in the history
- Support edge case where the node's parent is not immediate parentNode.
- Add contributing section into readme file.
- Adjust changelog file
- Bump up version to 1.2.4
  • Loading branch information
rickypc committed Aug 29, 2015
1 parent a05e0fe commit 2d7a2e5
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### 1.2.4 (2015.08.28)

* Bugfixes
* Update readme file

### 1.2.3 (2015.08.25)

* Bugfixes
Expand Down
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,16 @@ $ gulp

The `/dist` folder will contain distribution ready packages.

Contributing
-
If you would like to contribute code to Selenium Page Object Generator project you can do so through GitHub by forking the repository and sending a pull request.

When submitting code, please make every effort to follow existing conventions and style in order to keep the code as readable as possible. Please also include appropriate test cases.

Before your code can be accepted into the project you must also sign the [Selenium Page Object Generator CLA](https://goo.gl/forms/Bax4dq33Q7) (Individual Contributor License Agreement).

That's it! Thank you for your contribution!

License
-
Copyright (c) 2015 Richard Huang.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "selenium-page-object-generator",
"version": "1.2.3",
"version": "1.2.4",
"description": "A nimble and flexible Selenium Page Object Model generator to improve agile testing process velocity.",
"dependencies": {},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion src/chrome/assets/js/generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ window.POG=(function() {
var clonedParentNode = parentNode.cloneNode(true);
var clonedNode = clonedParentNode.querySelector(
node.nodeName.toLowerCase());
clonedParentNode.removeChild(clonedNode);
clonedNode.parentNode.removeChild(clonedNode);

text = clonedParentNode.textContent || clonedParentNode.innerText || '';
text = text.trim();
Expand Down

0 comments on commit 2d7a2e5

Please sign in to comment.