fix(navigator): disconnect notifier

rime · Jan 2, 2025 · b34e4ac · b34e4ac
1 parent 3a8ed90
commit b34e4ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/rime/gear/navigator.cc b/src/rime/gear/navigator.cc
@@ -61,10 +61,14 @@ Navigator::Navigator(const Ticket& ticket)
   LoadConfig(config, "navigator", Horizontal);
   LoadConfig(config, "navigator/vertical", Vertical);
 
-  engine_->context()->select_notifier().connect(
+  select_connection_ = engine_->context()->select_notifier().connect(
       [this](Context* ctx) { OnSelect(ctx); });
 }
 
+Navigator::~Navigator() {
+  select_connection_.disconnect();
+}
+
 ProcessResult Navigator::ProcessKeyEvent(const KeyEvent& key_event) {
   if (key_event.release())
     return kNoop;

diff --git a/src/rime/gear/navigator.h b/src/rime/gear/navigator.h
@@ -23,6 +23,7 @@ class Navigator : public Processor, public KeyBindingProcessor<Navigator, 2> {
   };
 
   explicit Navigator(const Ticket& ticket);
+  virtual ~Navigator();
 
   ProcessResult ProcessKeyEvent(const KeyEvent& key_event) override;
 
@@ -46,6 +47,8 @@ class Navigator : public Processor, public KeyBindingProcessor<Navigator, 2> {
 
   string input_;
   Spans spans_;
+
+  connection select_connection_;
 };
 
 }  // namespace rime