Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to risc0 1.2.1-rc.1 #138

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Upgrade to risc0 1.2.1-rc.1 #138

merged 11 commits into from
Jan 15, 2025

Conversation

hashcashier
Copy link
Contributor

@hashcashier hashcashier commented Jan 15, 2025

This PR updates zeth to the risc0 1.2.1-rc.1 release. Additionally it contains various patches and bug fixes for batch proofs.

Closes #135.
Closes #137.

@hashcashier hashcashier requested a review from Wollac January 15, 2025 07:57
@hashcashier hashcashier self-assigned this Jan 15, 2025
pub storage: HashMap<Address, StorageEntry>,
pub contracts: HashMap<B256, Bytecode>,
pub block_hashes: HashMap<u64, B256>,
pub storage: HashMap<Address, StorageEntry, NoMapHasher>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alloy-primitives has a specialized HashMap for those types like AddressMap or B256Map that follows a similar approach, but still protects against accidental and intentional HashDoS that makes the NoMapHasher dangerous. And starting with 0.8.16 it saw some big hash performance improvements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@hashcashier hashcashier merged commit 4e1ee0b into main Jan 15, 2025
7 checks passed
@hashcashier hashcashier deleted the rkhalil/1.2.1-rc.1 branch January 15, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants