Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed incrementation from compute_intersections call #62

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

jlheflin
Copy link
Contributor

There are two different increments that occur within the function, removing the increment within the final function call of the loop removes the n-plus-1 issue with the n body expansion.

Commenting out the ++starting_frag; line causes the program to stall, while removing the + 1 does not.

@ryanmrichard ryanmrichard merged commit 2ebd77e into master Jul 30, 2024
4 checks passed
@ryanmrichard ryanmrichard deleted the n-plus-one-fix branch July 30, 2024 20:02
@ryanmrichard
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v0.0.4 Changes:v0.0.3...v0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants