Upload CI simulation logs as an artifact #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoffeeCoder1
force-pushed
the
ci-simulation-logs
branch
from
206ea8e to
1aac4de
Compare
|
I feel like we could just review the logs in the action. We don't need to save every log just in case we want to review it at some point. |
These logs contain a lot of information that the standard output does not. Artifacts expire after a few months anyways (and this is configurable so we could make it even faster), and this could be handy in the future, especially if we end up implementing unit tests that use simulation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a step to the simulate CI step that uploads the logs as an artifact for later analysis.