Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Non-Maximum Merging (NMM) to Detections #500
Add Non-Maximum Merging (NMM) to Detections #500
Changes from 24 commits
c78ae33
57b12e6
9f22273
6f47046
5f0dcc2
166a8da
b159873
d7e52be
bee3252
97c4071
204669b
2eb0c7c
c3b77d0
8014e88
26bafec
d2d50fb
2d740bd
145b5fe
6c40935
53f345e
0e2eec0
559ef90
f8f3647
9024396
6fbca83
db1b473
0721bc2
530e1d0
2ee9e08
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't placing this code as part of the setitem method makes more sense? The flow below feels quite natural to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__setitam__
__getitam__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_set_at_index was not required. I removed it entirely, and did not add any logic to
__setitem__
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the arguments to
detections_1
anddetections_2
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think we have a naming problem. Our current
marge
should be calledconcatenate
, and this should be justmerge.
But as long asmerge_object_detection_pair
is not part of public API we don't need to overthink it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made an attempt to improve the naming: