Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstract members. #803

Merged
merged 18 commits into from
Dec 5, 2024
Merged

Add abstract members. #803

merged 18 commits into from
Dec 5, 2024

Conversation

knutnergaard
Copy link
Contributor

This PR adds abstract members to modules to handle [attr-defined] errors raised by mypy when methods defined only in subclasses are referenced in bases.

See error 5 on this list.

knutnergaard and others added 17 commits November 29, 2024 13:55
@knutnergaard
Resolve mypy errors.
d977313
@knutnergaard @github-actions
Format fixes by ruff
2036f83
@knutnergaard
Merge branch 'v1' into annotations
4d5f763
@knutnergaard
Improve annotation.
af60930 
- Add generic generic type arguments to view objects and `BaseDict`.
- Solve conflicting typing in `lib.py`.
- Adjust documentation.
@knutnergaard
Add abstract members.
e2edfa9
@knutnergaard @github-actions
Format fixes by ruff
866d5dd
@knutnergaard
Revert "Add abstract members."
3b0f4cb 
This reverts commit e2edfa9.
@knutnergaard
Add abstract members.
e2d10d6
@knutnergaard
Solve merge conflict.
3e45a6f
@knutnergaard
Revert to v1.
ac33aed
@knutnergaard
Correct implementation errors.
c152b9f 
- Add dynamic abstract dynamic properties to `PointPositionMixin`.
- Remove unused `PointPositionMixin` from `BaseImage`.
@knutnergaard
Merge branch 'v1' into abstract-members
466050c
@knutnergaard
Implement abstract members.
0837023
@knutnergaard @github-actions
Format fixes by ruff
9089845
@knutnergaard
Correct typo.
746f6f1
@knutnergaard
Merge branch 'abstract-members' of https://github.com/knutnergaard/fo…
2a1cb7c 
…ntParts into abstract-members
@knutnergaard
Delete superflous dashes.
65f78de
@knutnergaard knutnergaard marked this pull request as ready for review December 5, 2024 08:38
@knutnergaard
Copy link
Contributor Author

@benkiel I had to override the abstract members defined in _BaseGlyphVendor in BaseLayer to keep the class concrete. Ideally I guess these methods shouldn't be shared between BaseFont and BaseLayer from a common mixin, but this way, no refactoring is strictly necessary.

@knutnergaard knutnergaard mentioned this pull request Dec 5, 2024
Open
@knutnergaard knutnergaard deleted the abstract-members branch December 5, 2024 09:35
@knutnergaard knutnergaard restored the abstract-members branch December 5, 2024 11:31
@knutnergaard
Copy link
Contributor Author

@benkiel I inadvertently deleted the remote abstract-members branch, which seems to have closed this PR. Should be ok now. Can you reopen it?

@benkiel benkiel reopened this Dec 5, 2024
@benkiel
Copy link
Member

benkiel commented Dec 5, 2024

@knutnergaard reopened

@benkiel benkiel merged commit 4629a4b into robotools:v1 Dec 5, 2024
30 checks passed
@knutnergaard knutnergaard deleted the abstract-members branch December 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkiel benkiel benkiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knutnergaard @benkiel