Add and use pkcs12 in tls-crypt-v2 e2e test

[reynir]

This will exercise some of the pkcs12 code.

I also removed unused symbolic links.

[reynir]

I added a test with peer-fingerprint too, but --peer-fingerprint is OpenVPN>=2.6 so doesn't work with CI.

[hannesm]

I opened #273 to get openvpn 2.6 installed on the GitHub worker (following the OpenVPN instructions). I guess that would be nice for this here as well :)

[hannesm]

I'm undecided about the output here.. somehow it is nice to spot the issues easily in CI, somehow it is also nice to not get a lot of output.

In the end, I'm fine without the redirection to /dev/null. if there's need to see less output, someone invoking the scripts can still redirect to /dev/null. :)

[reynir]

I removed the redirection to /dev/null to debug in CI. We should add it back, I just forgot.

[hannesm]

looks good to me

[reynir]

The two numbers are unfortunately not 100% comparable as for the 2nd numbers I rebased on #273 which covers more code as well. While rebasing I also dropped the "debug" commit which removed the redirection to /dev/null.

[hannesm]

The other PR was at 72.76%, here we're nearly 1% more.

[reynir]

I squashed the fixup commit before merging

[github-actions]

  0.00 %      0/21     src/cc_message.ml
 80.28 %   1482/1846   src/config.ml
 57.64 %    117/203    src/config_ext.ml
 94.74 %     18/19     src/cstruct_ext.ml
 64.51 %    847/1313   src/engine.ml
100.00 %      0/0      src/miragevpn.ml
 92.88 %    365/393    src/packet.ml
 20.00 %      1/5      src/result.ml
 63.41 %     52/82     src/state.ml
 61.48 %    150/244    src/tls_crypt.ml
 73.49 %   3032/4126   Project coverage

[reynir]

Hmm the coverage dropped slightly after re-adding the /dev/null redirection. My guess is some code paths are slightly timing sensitive in our tests?!

[hannesm]

Should we remove the redirects? As mentioned above, fine with me.