Skip to content

Commit

Permalink
Merge pull request #7210 from roc-lang/ignore_debug_exceptions_in_all…
Browse files Browse the repository at this point in the history
…_contexts

ignore test debug exceptions in all contexts
  • Loading branch information
Anton-4 authored Nov 9, 2024
2 parents 119663b + 4249cd4 commit db017de
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ubuntu_x86_64_nix_debug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ jobs:

# for skipped tests; see #6946, #6947
- name: cargo test without --release
run: nix develop -c sh -c 'export ROC_CHECK_MONO_IR=1 && cargo test -- --skip tests/exhaustive/match_on_result_with_uninhabited_error_destructuring_in_lambda_syntax.txt --skip tests::identity_lambda --skip tests::issue_2300 --skip tests::issue_2582_specialize_result_value --skip tests::sum_lambda'
run: nix develop -c sh -c 'export ROC_CHECK_MONO_IR=1 && cargo test'
8 changes: 8 additions & 0 deletions crates/compiler/uitest/src/uitest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ fn collect_uitest_files() -> io::Result<Vec<PathBuf>> {
}

if path.extension() == Some(OsStr::new("txt")) {
// see issue 6947
if cfg!(debug_assertions)
&& path.to_string_lossy().contains(
"match_on_result_with_uninhabited_error_destructuring_in_lambda_syntax",
)
{
continue;
}
tests.push(path);
}
}
Expand Down
11 changes: 8 additions & 3 deletions crates/repl_test/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -624,12 +624,15 @@ fn list_of_3_field_records() {
);
}

// not(debug_assertions) because of issue #6946
#[cfg(not(debug_assertions))]
#[test]
fn identity_lambda() {
expect_success("\\x -> x", "<function> : a -> a");
}

#[cfg(not(feature = "wasm"))]
// not(debug_assertions) because of issue #6946
#[cfg(all(not(feature = "wasm"), not(debug_assertions)))]
#[test]
fn sum_lambda() {
expect_success("\\x, y -> x + y", "<function> : Num a, Num a -> Num a");
Expand Down Expand Up @@ -1049,7 +1052,8 @@ fn large_nullable_wrapped_tag_union() {
)
}

#[cfg(not(feature = "wasm"))]
// not(debug_assertions) because of issue #6946
#[cfg(all(not(feature = "wasm"), not(debug_assertions)))]
#[test]
fn issue_2300() {
expect_success(
Expand Down Expand Up @@ -1330,7 +1334,8 @@ fn box_box_type_alias() {
}

#[test]
#[cfg(not(feature = "wasm"))]
// not(debug_assertions) because of issue #6946
#[cfg(all(not(feature = "wasm"), not(debug_assertions)))]
fn issue_2582_specialize_result_value() {
expect_success(
r#"\x, list -> if x > 0 then List.first list else Ok """#,
Expand Down

0 comments on commit db017de

Please sign in to comment.