Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Final task - improve language & grammar. User-specified endpoint #1339

Merged
merged 4 commits into from
Nov 18, 2023

Conversation

ValtsS
Copy link
Contributor

@ValtsS ValtsS commented Nov 16, 2023

Instead of hard-coded API provide option for user to change the GraphQL endpoint.
Support of Unicode passwords.
Add code smell penalty from previous tasks.

Instead of hard-coded API provide option for user to change the GraphQL endpoint.
react/modules/graphiql.md Outdated Show resolved Hide resolved
react/modules/graphiql.md Outdated Show resolved Hide resolved
@valerydluski
Copy link
Collaborator

looks good to me. @ValtsS thank you

@kravaring
Copy link
Collaborator

Thank you, @ValtsS!
All changes look good now.

@kravaring kravaring merged commit 33ca5e3 into rolling-scopes-school:master Nov 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants