Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homologate Smac & MPPI: getInflationLayer (easy) #4066

Closed
SteveMacenski opened this issue Jan 25, 2024 · 2 comments
Closed

Homologate Smac & MPPI: getInflationLayer (easy) #4066

SteveMacenski opened this issue Jan 25, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@SteveMacenski
Copy link
Member

SteveMacenski commented Jan 25, 2024

Recently a new static getInflationLayer() method was added to the inflation layer to get the inflation layer out of a stack of layers in the layered costmap. This was added by a PR to add additional intelligence to the Smac Planner in heuristic computation for non-circular footprints. This logic was largely lifted from MPPI's obstacle critic to find the inflation layer, so rather than putting it in Smac, it was added to a third party location so they can be shared (i.e. homologated).

The task is to take this new function and apply it to the Obstacle critic: https://github.com/ros-planning/navigation2/blob/main/nav2_mppi_controller/src/critics/obstacles_critic.cpp#L55-L101

New Fn introduced here: #4067

@SteveMacenski SteveMacenski added the good first issue Good for newcomers label Jan 25, 2024
@jncfa
Copy link
Contributor

jncfa commented Jan 26, 2024

Recently a new static getInflationLayer() method was added to the inflation layer to get the inflation layer out of a stack of layers in the layered costmap. This was added by a PR to add additional intelligence to the Smac Planner in heuristic computation for non-circular footprints. This logic was largely lifted from MPPI's obstacle critic to find the inflation layer, so rather than putting it in Smac, it was added to a third party location so they can be shared (i.e. homologated).

The task is to take this new function and apply it to the Obstacle critic: https://github.com/ros-planning/navigation2/blob/main/nav2_mppi_controller/src/critics/obstacles_critic.cpp#L55-L101

New Fn introduced here: #4067

I assume you would also want to replace it here, correct? https://github.com/ros-planning/navigation2/blob/main/nav2_smac_planner/include/nav2_smac_planner/utils.hpp#L82-L97

I can make a quick MR for this if you want

@SteveMacenski
Copy link
Member Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants