Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several users have been reporting numerical issues with careless. Recently, I was able to reproduce them, and I tracked the issue down to an overflow in the scale parameter of the normal distribution which parameterizes the reflection scales. The default bijector here has been the exponential for sometime. However, apparently it does not work stably for some data sets (probably those with particularly bright reflections). One solution would be to normalize the intensities in the likelihood calculation. This might be worth exploring in the future. For now, I have changed the default bijector back to softplus and added a command line flag
--scale-bijector={exp,softplus}
.