-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency gemmi to >=0.5.5, <=0.7.0 #284
base: main
Are you sure you want to change the base?
Conversation
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
The above commits address the changes to the |
I was able to reproduce this issue locally. The cause is that calling I'm not sure why this reproduced on my machine and not yours, @JBGreisman. I suppose the biggest difference is probably linux vs mac os. |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
- Coverage 88.98% 88.68% -0.30%
==========================================
Files 40 40
Lines 2841 2855 +14
==========================================
+ Hits 2528 2532 +4
- Misses 313 323 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
That's unexpected. Is it a |
Yes, sorry for the confusion. It's a
Thanks for the suggestion, I'll modify our test to use the |
awesome -- thanks for sorting this out, @kmdalton, and thanks for the suggestion @wojdyr. This behavior only crops up with numpy >2, which is what the issue was with my local version. When I bump my numpy version, I see these failed tests related to the float/complex dtype. I think this is ready to go, but please let me know if you think there are any remaining issues related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
one particular problem, for copy=False, was that astype(None) was called resulting in casting complex values to real with warning: ComplexWarning: Casting complex values to real discards the imaginary part as reported in rs-station/reciprocalspaceship#284
Thanks for spotting the issues in gemmi. I fixed the |
This PR contains the following updates:
>=0.5.5, <=0.6.7
->>=0.5.5, <=0.7.0
Release Notes
project-gemmi/gemmi (gemmi)
v0.7.0
: 0.7.0Compare Source
C++14 (or later) is required to build the library, C++17 (or later) to build Python bindings.
Expect breaking changes, especially in Python bindings.
The lists below are not complete, but should cover most of the changes.
Library
Model::name
with intModel::num
order
that can be 0 (nearest value), 1 (linear interpolation), or 3 (cubic). In C++ there are also functions such as trilinear_interpolation() to ensure no overhead.[metals]
and[nonmetals]
.read_cif
argsPython
__array__
methods.For NumPy, you can also use
.array
properties that were available also in the previous releases.site-packages/gemmi/
(this change should be invisible to the user)Program
pdbx_F_calc_with_solvent
toF-model
(+phase)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.