Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitlab): support relative URL for gilab server #1454

Closed
wants to merge 1 commit into from

Conversation

selmison
Copy link

This change fixes that bug (#1450).

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #1454 (ff20e6b) into master (8ca6e16) will decrease coverage by 0.03%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   69.58%   69.55%   -0.04%     
==========================================
  Files          93       93              
  Lines        6332     6335       +3     
==========================================
  Hits         4406     4406              
- Misses       1549     1551       +2     
- Partials      377      378       +1     
Impacted Files Coverage Δ
server/events/models/models.go 73.57% <40.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca6e16...ff20e6b. Read the comment docs.

@selmison selmison changed the title Support basepath for gilab server Support relative URL for gilab server Mar 24, 2021
Copy link
Contributor

@nishkrishnan nishkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@chenrui333 chenrui333 changed the title Support relative URL for gilab server feat(gitlab): support relative URL for gilab server Mar 7, 2022
@jamengual
Copy link
Contributor

@selmison can you add some tests? thanks for the contribution

@jamengual jamengual added the waiting-on-response Waiting for a response from the user label May 13, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 13, 2022
@github-actions github-actions bot closed this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/gitlab waiting-on-response Waiting for a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants