-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment Variable List of Structs #597
base: main
Are you sure you want to change the base?
Conversation
closes #603 No breaking changes in this PR, should be fully backward compatible. |
@epage or @matthiasbeyer any chance I could get one of you to take a look? |
match (&mut self.kind, other.kind) { | ||
(ValueKind::Table(ref mut table), ValueKind::Table(other_table)) => { | ||
for (k, v) in other_table { | ||
match table.entry(k) { |
Check failure
Code scanning / clippy
mismatched types Error
match (&mut self.kind, other.kind) { | ||
(ValueKind::Table(ref mut table), ValueKind::Table(other_table)) => { | ||
for (k, v) in other_table { | ||
match table.entry(k) { |
Check failure
Code scanning / clippy
mismatched types Error
(ValueKind::Table(ref mut table), ValueKind::Table(other_table)) => { | ||
for (k, v) in other_table { | ||
match table.entry(k) { | ||
std::collections::hash_map::Entry::Occupied(mut entry) => { |
Check failure
Code scanning / clippy
mismatched types Error
for (k, v) in other_table { | ||
match table.entry(k) { | ||
std::collections::hash_map::Entry::Occupied(mut entry) => { | ||
entry.get_mut().merge(v); |
Check failure
Code scanning / clippy
type annotations needed Error
std::collections::hash_map::Entry::Occupied(mut entry) => { | ||
entry.get_mut().merge(v); | ||
} | ||
std::collections::hash_map::Entry::Vacant(entry) => { |
Check failure
Code scanning / clippy
mismatched types Error
Sorry, I had forgotten to change my watch status for this repo. My general approach is that PRs should not be reviewed, or generally posted, until use cases and requirements are understood and we've agreed to a design. See also https://github.com/rust-cli/config-rs/blob/main/CONTRIBUTING.md#pull-requests |
Pull Request Test Coverage Report for Build 11611055215Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Enables specifying lists of structs within environment variables.
Example