ci: simplify, test MSRV. #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
msrv-ci
branch
7 times, most recently
from
3e1da09 to
c2faac6
Compare
- Use separate jobs instead of `matrix`. The Github Actions matrix is very cursed, especially if you use `include`. We don't have that many combinations, IMO doing separate jobs is way more straightforward and only slightly more verbose. - `embedded-hal` needs `rust-version = 1.60` because it uses `dep:`. Fixes rust-embedded#538
|
needs updating repo settings, will do after PR approval. |
|
I have already updated the branch protection rules as these needed to be updated before the merge. Otherwise some required builds were missing. |
|
Now we are missing a build without features, though. That might be a good addition. |
the |
|
Ah, I missed that. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix. The Github Actions matrix is very cursed, especially if you useinclude. We don't have that many combinations, IMO doing separate jobs is way more straightforward and only slightly more verbose.embedded-halneedsrust-version = 1.60because it usesdep:.Fixes #538