Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion to io::Error #77

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

scootermon
Copy link
Contributor

I'm not sure if this repository is still being maintained, but the crate is still very useful when working with older Linux kernels.

This PR adds a simple implementation for mapping this crate's custom error type to std::io::Error. Having this impl is useful when interacting with other functions that return std::io::Result.

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!
Could you add an entry to the changelog?
However, the CI is currently broken due to unrelated issues. We can merge this afterwards.

@nastevens
Copy link
Member

Hey @scootermon - the CI fixes are merged, so if you can merge or rebase with your changes we can get this merged. Thanks again for your contribution!

@scootermon
Copy link
Contributor Author

Thanks, @nastevens. I went ahead and rebased the PR.

@nastevens nastevens merged commit 04cb2c0 into rust-embedded:master May 13, 2024
46 checks passed
@nastevens
Copy link
Member

Thanks again for the contribution @scootermon!

@nastevens
Copy link
Member

sysfs_gpio 0.6.2 published: https://crates.io/crates/sysfs-gpio/0.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants