Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Render timing pipeline in SVG #15091

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

eth3lbert
Copy link
Contributor

What does this PR try to resolve?

This PR renders the timing pipeline in SVG, which should hopefully resolve #8850.

Additional information

This does not guarantee a pixel-perfect match from the previous canvas-based solution, but I maintain it stays as close as possible.

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-timings Area: timings S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2025
@eth3lbert eth3lbert force-pushed the timings-pipeline-svg branch from ac8c105 to 8761588 Compare January 22, 2025 14:18
@ehuss
Copy link
Contributor

ehuss commented Jan 22, 2025

For context, the original version of this used SVG. However, it was switched to canvas due to severe rendering performance problems on some systems and browsers. Has this been thoroughly tested on multiple browsers, and on systems with limited video cards, and different platforms?

@eth3lbert
Copy link
Contributor Author

For context, the original version of this used SVG.

Yeah, I noticed this part.

Has this been thoroughly tested on multiple browsers, and on systems with limited video cards, and different platforms?

No, I haven't tested it with legacy devices or systems, only the newest Firefox and Chrome. Testers and feedback are welcome :D

@weihanglo
Copy link
Member

However, it was switched to canvas due to severe rendering performance problems on some systems and browsers

Any chance to recall those legacy systems and browsers?

@ehuss
Copy link
Contributor

ehuss commented Jan 23, 2025

Any chance to recall those legacy systems and browsers?

It was probably a 2018-era Intel integrated UHD Graphics 630 or AMD Radeon Pro 560X with an Intel Core i7 (macbook). I think Firefox was one of the worst in performance, but Safari and Chrome were also pretty bad. I believe Firefox has improved its SVG rendering since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-timings Area: timings S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo timings graph is broken in Firefox
4 participants