Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #4224

Closed
wants to merge 1 commit into from
Closed

fix: typos #4224

wants to merge 1 commit into from

Conversation

chloefeal
Copy link

I hope my corrections will help you. Thank you for your work.

@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@tgross35
Copy link
Contributor

tgross35 commented Dec 28, 2024

Thanks for the PR, could you provide a link to the headers where these are defined? Or a snip since I think these are private.

@chloefeal
Copy link
Author

Sorry, maybe I am disunderstand.

@chloefeal chloefeal closed this Dec 28, 2024
@tgross35
Copy link
Contributor

The correction is definitely welcome if it makes things more consistent with NTO's sources, but if they have that typo then I think we unfortunately need to keep the same typo.

@chloefeal
Copy link
Author

@tgross35 Agree with you. It's better to make fix to upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants