Add newlib sqrtf #172
Closed
Add newlib sqrtf #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc #170 |
tesuji
force-pushed
the
newlib-sqrtf
branch
2 times, most recently
from
3de3293 to
58eaf27
Compare
|
Thanks for the PR! I have the same questions as #169 for this though. Why is this change being made relative to what's currently already implemented? |
Closed
This reverts commit 4bbd418.
|
Is this just a reorganization of what's already there at this point? If so, why is this PR needed? |
|
Seems like we don't agree the merge this. Closing then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported sqrtf from https://github.com/eblot/newlib/blob/master/newlib/libm/math/ef_sqrt.c .
r? @japaric
Blocked on #173