distinguish no_std code

rust-lang · Jan 6, 2025 · ae5b740 · ae5b740
1 parent c5a2ba5
commit ae5b740
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/clippy_lints/src/too_owned.rs b/clippy_lints/src/too_owned.rs
@@ -4,8 +4,8 @@ use rustc_errors::Applicability;
 use rustc_hir as hir;
 use rustc_lint::{LateContext, LateLintPass};
 use rustc_session::declare_lint_pass;
-use rustc_span::symbol::sym;
 use rustc_span::Span;
+use rustc_span::symbol::sym;
 
 declare_clippy_lint! {
     /// ### What it does
@@ -71,11 +71,19 @@ fn replacement(cx: &LateContext<'_>, cty: &hir::Ty<'_>) -> Option<(Span, String)
             None
         };
     }
-    for (diag, repl) in [
-        (sym::cstring_type, "std::ffi::CStr"),
-        (sym::OsString, "std::ffi::OsStr"),
-        (sym::PathBuf, "std::path::Path"),
-    ] {
+    if clippy_utils::is_path_diagnostic_item(cx, cty, sym::cstring_type) {
+        return Some((
+            cty.span,
+            (if clippy_utils::is_no_std_crate(cx) {
+                "core::ffi::CStr"
+            } else {
+                "std::ffi::CStr"
+            })
+            .into(),
+        ));
+    }
+    // Neither OsString nor PathBuf are available outside std
+    for (diag, repl) in [(sym::OsString, "std::ffi::OsStr"), (sym::PathBuf, "std::path::Path")] {
         if clippy_utils::is_path_diagnostic_item(cx, cty, diag) {
             return Some((cty.span, repl.into()));
         }