Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix: add support for RTM_NEWPREFIX #91

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

deastoe
Copy link
Contributor

@deastoe deastoe commented Dec 22, 2023

I implemented this against an older version of netlink-packet-route (0.7.0) some time ago, and only recently got around to rebasing and upstreaming it. Hopefully the diffs are consistent with the intervening changes to the crate structure and patterns :-).

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (0219628) 63.64% compared to head (1065dab) 64.02%.

Files Patch % Lines
src/message.rs 0.00% 9 Missing ⚠️
src/prefix/attribute.rs 83.33% 5 Missing ⚠️
src/prefix/message.rs 90.62% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   63.64%   64.02%   +0.37%     
==========================================
  Files         134      139       +5     
  Lines        8484     8642     +158     
==========================================
+ Hits         5400     5533     +133     
- Misses       3084     3109      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@cathay4t cathay4t merged commit 2a43e1c into rust-netlink:main Jan 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants