Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial dynamic weather support #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lihis
Copy link
Collaborator

@Lihis Lihis commented Jan 5, 2025

This has been work-in-progress (see Lihis#2) for a while and I will not have time to finish any time soon so I think it might be better to get this merged in its current state so someone can improve it at some point.

I have not tested this against latest main but I'll try to do it within few weeks or so.

Copy-paste from PR in my fork of the repo:


Tasklist and some details:

  • Weather cycles according the weather list for GTA III.
  • Verify is the above weather list same for:
    • v1.1
    • Steam version
  • Rain droplets in rainy weather
  • Weather can be controlled by opcodes and it behaves according them:
    • 01B5: Force next weather (see Dynamic weather conditions #379 (comment)). Weather does not cycle until released (via 01B7).
    • 01B6: Force weather now; weather is immediately set to requested weather. Weather does not cycle until released (via 01B7).
    • 01B7: Release weather; continue weather cycle from where it was.
    • 0251: Store weather; unused.
    • 0251: Restore weather; unused.
  • New game:
    • Weather cycle starts from array index 0?
  • Load game:
    • Clean save without weather cheats; weather cycle continues from the saved state.
    • "Dirty" save where a weather cheat used; weather does not cycle, weather is kept in the forced state.
  • Write simple SCM for testing opcode 01B5.
  • Did miss something? Yes/No: TBD

@Lihis Lihis mentioned this pull request Jan 5, 2025
16 tasks
Copy link
Contributor

@okias okias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look like a good start

rwengine/src/data/Weather.hpp Show resolved Hide resolved
rwgame/RWGame.cpp Outdated Show resolved Hide resolved
@Lihis Lihis requested a review from okias January 9, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants