-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging my changes from multiple pull requests #44
Open
alexandro-rezakhani
wants to merge
18
commits into
rxi:master
Choose a base branch
from
alexandro-rezakhani:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running this code in locales that do not use a period for floating point integers, an error would occur. This is now resolved.
previous version was replacing minus sign in negative numbers in error.
…numbers are encoding improved.
… The array detection code now allows for the array to have a key n with a number value to detect the array length.
Update info about supporting Lua 5.4 version
@kyl3n Fixed locale floating point character
@aryajur Improved table encoding code to handle sparse arrays.
…tch-1 Update json.lua
Took advice from @Dnsls and @Faserr to optimize code from rxi#34. rxi#34 rxi#34 (comment) rxi#34 (comment)
…tch-1 Optimize code
fix rxi#41: Large numbers serialized incorrectly
i was unable to encode a table due to some number based key properties. i modified the encode function to check for number based keys in addition to the already present string based keys. an error will still be returned if the key is neither string nor number based. it works in my cases Please see this link: rxi#43 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.