Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: set trigger value in jet constituent QA #1030

Merged

Conversation

ruse-traveler
Copy link
Contributor

@ruse-traveler ruse-traveler commented Dec 20, 2024

This PR fixes a minor bug: the trigger flag value wasn't being provided in the call to ConstituentsInJets::setTrgStoSelect(), so this module was always selecting the MBDNS >= 1 trigger.

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit c1ba9a12d38db5a8a0083651cb2a14af7a9c30d6. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@bseidlit
Copy link
Contributor

bseidlit commented Dec 20, 2024

Isn't TriggerRunInfoReco nodes already in the DSTs at this stage of the prod? it is in the calo fitting macro. If it is being striped out accidentally we should fix that.

@ruse-traveler
Copy link
Contributor Author

Isn't TriggerRunInfoReco nodes already in the DSTs at this stage of the prod? it is in the calo fitting macro. If it is being striped out accidentally we should fix that.

Whoops! Good catch! I forgot about that! I'll double check that it isn't being stripped out. We do need the bugfix in the constituents, though, so I'll reduce the scope of this PR to just that...

@ruse-traveler ruse-traveler changed the title Reconstruct trigger info in jet QA macros Bugfix: set trigger value in jet constituent QA Dec 26, 2024
@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit c5bb2f2f3eafbf3c128cc109e8e2ba8b46d2a638. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@ruse-traveler
Copy link
Contributor Author

This is now descoped!

@pinkenburg pinkenburg merged commit 0bff943 into sPHENIX-Collaboration:master Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants