Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Suite of Jet Workflows #992

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ruse-traveler
Copy link
Contributor

@ruse-traveler ruse-traveler commented Nov 9, 2024

This PR extends the suite of possible jet reconstruction workflows to include non-background-subtracted calorimeter, track, and particle-flow jets, and to include background-subtracted track and particle-flow jets. This will help centralize jet reconstruction for non-background-subtracted and track-based analyses, and step towards integrating track jets into the jet QA.

For the former point, a new macro, NonBkgdSubJetReco.C, has been added to the common macros. And for the latter, HIJetReco.C has been reorganized to allow the user to run jet reconstruction on tracks and particle-flow elements.

Note that since background-subtraction routines for track jets and particle-flow jets are still under development, the routines in HIJetReco.C are placeholders that should be filled in later. The macro will emit a warning saying as much.

TO-DO


  • Confirm that track jet reconstruction is actually doing what it should
  • Add PF jet reconstruction
  • Add warnings if running track/PF jet reco in HIJetReco
  • Add no-subtraction macro
  • Get sign-offs from:
    • JS TG
    • HF/Q TG
    • cQCD TG

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit ed9de137b15d1bca50a8763a35630b09906cbcc6. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit 1715767ffc4bf2a4bf417cc5f94b19c523fc8ada. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit d96bb6575fca01d3c1ff5a85f7dbcdbcf41925dc. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@ruse-traveler ruse-traveler marked this pull request as ready for review November 12, 2024 14:21
@ruse-traveler ruse-traveler marked this pull request as draft November 14, 2024 19:08
@ruse-traveler
Copy link
Contributor Author

Summary of discussion w/ JS TG and offline discussion w/ @KvapilJ , @xuanli23 , @zhiwanxu:

  • The HIJetReco macro is specifically for background subtracted jets, so it could be confusing to mix background-subtracted & non-background-subtracted workflows. One fix could be to add a doBkgdSub flag and emit a warning that background subtraction isn't implemented yet for charged/PF jets when running those.
  • However, there are use cases (e.g. HF-tagged jets) where doing no background subtraction is preferable. It might be useful to have a macro explicitly for such workflows

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit 2928f32f2204e6cf5a1ede402ce80613483da7a5. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@ruse-traveler ruse-traveler changed the title Add track and particle flow jet reconstruction Extend Suite of Jet Workflows Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant