Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue relate to number of argument being passed to migrate function of l2_migration_contract #465

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/safe_cli/operators/safe_operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -726,9 +726,10 @@ def update_version_to_l2(
fallback_handler = safe_deployments["1.3.0"][
"CompatibilityFallbackHandler"
][str(chain_id)]
# Assuming last element of array safe_l2_singleton and fallback_handler is the latest version.
data = HexBytes(
l2_migration_contract.functions.migrateFromV111(
safe_l2_singleton, fallback_handler
safe_l2_singleton[-1], fallback_handler[-1]
).build_transaction(get_empty_tx_params())["data"]
)
elif safe_version in ("1.3.0", "1.4.1"):
Expand All @@ -738,7 +739,7 @@ def update_version_to_l2(
fallback_handler = self.safe_cli_info.fallback_handler
data = HexBytes(
l2_migration_contract.functions.migrateToL2(
safe_l2_singleton
safe_l2_singleton[-1]
).build_transaction(get_empty_tx_params())["data"]
)
else:
Expand Down