Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature EIP-7702 docs #651

Merged
merged 28 commits into from
Dec 4, 2024
Merged

Feature EIP-7702 docs #651

merged 28 commits into from
Dec 4, 2024

Conversation

akshay-ap
Copy link
Member

@akshay-ap akshay-ap commented Nov 28, 2024

Fixes https://github.com/safe-global/developer-experience/issues/313
Changes in PR:

  • Add introductory section for EIP-7702
  • Add problem with using existing Safe contracts with EIP-7702
  • Add possible approaches for using Safe with EIP-7702
  • Added diagrams

@akshay-ap akshay-ap marked this pull request as draft November 28, 2024 09:59
Copy link

github-actions bot commented Nov 28, 2024

Branch preview

✅ Deployed successfully in branch deployment:

https://feature_eip_7702_docs--docs.review.5afe.dev

Copy link

github-actions bot commented Nov 28, 2024

Overall readability score: 30.86 (🔴 -0.49)

File Readability
7702-safe.mdx 58.67 (-)
overview.mdx 57.46 (-)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
7702-safe.mdx 58.67 44.64 10.11 12.7 12.29 6.93
  - - - - - -
overview.mdx 57.46 48.7 10.06 11 12.11 8.39
  - - - - - -

Averages:

  Readability FRE GF ARI CLI DCRS
Average 30.86 26.87 13.64 17.75 15.81 8.96
  🔴 -0.49 🔴 -0.46 🟢 +0.06 🔴 -0.33 🔴 -0.06 🟢 +0.02
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@akshay-ap akshay-ap self-assigned this Nov 28, 2024
@akshay-ap akshay-ap marked this pull request as ready for review November 28, 2024 14:21
@akshay-ap akshay-ap force-pushed the feature-eip-7702-docs branch from 8773b23 to 86771c2 Compare November 28, 2024 14:29
@tanay1337 tanay1337 removed their request for review November 29, 2024 09:18
@germartinez
Copy link
Member

germartinez commented Dec 3, 2024

I updated the style of the diagrams. Can we use this version instead?

Screenshot 2024-12-03 at 17 26 41
Screenshot 2024-12-03 at 17 20 16
Screenshot 2024-12-03 at 17 20 36

@akshay-ap akshay-ap force-pushed the feature-eip-7702-docs branch from d6e4ace to 36c4a43 Compare December 4, 2024 11:25
@akshay-ap akshay-ap merged commit 8052548 into main Dec 4, 2024
4 checks passed
@akshay-ap akshay-ap deleted the feature-eip-7702-docs branch December 4, 2024 13:42
akshay-ap added a commit that referenced this pull request Dec 6, 2024
* Add content on EIP-7702

* Add content on each possible approach for EIP-7702

* Add diagrams for 7702, minor text update

* Update link to 7702 Demo

* [EIP-7702] Update presentation link, update diagrams

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* [EIP-7702] Convert note to callout

* Fix typo

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/overview.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

* Update pages/advanced/eip-7702/7702-safe.mdx

Co-authored-by: Germán Martínez <[email protected]>

---------

Co-authored-by: Germán Martínez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants