Remove price calculation #1762
Remove price calculation #1762
Conversation
moisses89
force-pushed
the
remove_price_service
branch
from
c9640a7 to
225cdc9
Compare
moisses89
force-pushed
the
remove_price_service
branch
from
47fb133 to
dacb44b
Compare
|
@Uxio0 this shouln´t be included on the next release until 30th November but could be in staging until that day. |
| @@ -72,6 +67,11 @@ def get_price_address(self) -> ChecksumAddress: | |||
| return self.token_address | |||
|
|
|||
|
|
|||
| class FiatCode(Enum): | |||
| USD = 1 | |||
| EUR = 2 | |||
There was a problem hiding this comment.
I added this Enum class while we keep balance with price. I think that we should do this in other issue because this needs to be coordinated with clients, for example safe-client-gateway.
| round(123.4 * 0.4 * (tokens_value / 1e18), 4), | ||
| round(123.4 * 0.4, 4), | ||
| 0.0, | ||
| datetime.datetime.utcfromtimestamp(0), |
There was a problem hiding this comment.
From clients atre expected a date, how we cannot say when was calculated I decided to put epoch 0.
| 0.0, | ||
| datetime.utcfromtimestamp(0), | ||
| 0.0, | ||
| 0.0, | ||
| FiatCode.USD.name, | ||
| ) |
There was a problem hiding this comment.
@hectorgomezv just to inform you, the transaction service will return eth_value as 0, timestamp when was calculated as 1970-01... (epoch 0), fiat_balance 0 and fiat_conversion as 0.
This is affecting the endpoint /v1/safes/{address}/balances/usd/
There was a problem hiding this comment.
Thank you @moisses89! No problem at all from the CGW perspective, the service is not using that endpoint anymore.
Closes #1758