Fix SafeRelevantTransaction default timestamp #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
requested changes
Nov 27, 2024
| @@ -603,7 +603,7 @@ def __process_decoded_transaction( | |||
| SafeRelevantTransaction.objects.get_or_create( | |||
| ethereum_tx=ethereum_tx, | |||
| safe=contract_address, | |||
| defaults={"timestamp": ethereum_tx.created}, | |||
| defaults={"timestamp": ethereum_tx.block.timestamp}, | |||
There was a problem hiding this comment.
It is the related field included in the queryset ethereum_tx?
If not this will create a new request to database for each ethereum_tx.
There was a problem hiding this comment.
Fixed using internal_tx 👍
Uxio0
requested changes
Nov 27, 2024
Co-authored-by: Uxío <[email protected]>
Co-authored-by: Uxío <[email protected]>
Uxio0
approved these changes
Nov 28, 2024
moisses89
approved these changes
Nov 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when reindexing a safe, if a missing Tx appears, it is being inserted with the current date instead of the correct date.
This causes an order problem in the
all-transactionsendpoint.