Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable Add proposer button for owners only #4744

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #4743

How this PR fixes it

  • Adds a new HoC called OnlyOwner and uses it for the Add proposer button instead of the CheckWallet component

How to test it

  1. Open a Safe
  2. Go to the Settings page
  3. Connect with an owner
  4. The Add proposer button is enabled
  5. Connect with a different wallet e.g. spending limit beneficiary, proposer, nested safe owner, recoverer
  6. Observe that the add proposer button is disabled

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Jan 7, 2025

@usame-algan
Copy link
Member Author

I decided to write a new component instead of adjusting CheckWallet because its already way too complex and I don't want to take the risk of breaking another place where CheckWallet is used.

Copy link

github-actions bot commented Jan 7, 2025

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1 MB (🟡 +14.91 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 508 B (🟢 -2 B) 1 MB
/address-book 23.21 KB (🟡 +142 B) 1.03 MB
/apps 35.8 KB (🟡 +2.08 KB) 1.04 MB
/apps/custom 33.87 KB (🟡 +2.08 KB) 1.04 MB
/apps/open 55.57 KB (🟡 +1.96 KB) 1.06 MB
/balances 29.88 KB (🟡 +176 B) 1.03 MB
/balances/nfts 9.52 KB (🟢 -24 B) 1.01 MB
/bridge 2.56 KB (🟡 +1 B) 1.01 MB
/cookie 8.77 KB (🟡 +1 B) 1.01 MB
/home 61.38 KB (🟡 +2.12 KB) 1.06 MB
/new-safe/advanced-create 26.38 KB (🟢 -75 B) 1.03 MB
/new-safe/create 25.52 KB (🟢 -74 B) 1.03 MB
/new-safe/load 6.08 KB (🟢 -5 B) 1.01 MB
/privacy 14.57 KB (🟡 +2 B) 1.02 MB
/settings/appearance 2.25 KB (🟡 +2 B) 1.01 MB
/settings/environment-variables 3.27 KB (🟢 -1 B) 1.01 MB
/settings/modules 4.06 KB (🟡 +1 B) 1.01 MB
/settings/notifications 21 KB (🟢 -324 B) 1.02 MB
/settings/safe-apps 20.35 KB (🟡 +2.08 KB) 1.02 MB
/settings/security 2.34 KB (🟡 +1 B) 1.01 MB
/settings/setup 30.94 KB (🟡 +215 B) 1.03 MB
/share/safe-app 7.56 KB (🟢 -5 B) 1.01 MB
/stake 618 B (🟢 -1 B) 1 MB
/swap 764 B (🟡 +4 B) 1 MB
/terms 12.93 KB (🟡 +1 B) 1.02 MB
/transactions 99.47 KB (🟡 +2.9 KB) 1.1 MB
/transactions/history 99.43 KB (🟡 +2.9 KB) 1.1 MB
/transactions/messages 60.26 KB (🟡 +1.96 KB) 1.06 MB
/transactions/msg 56.51 KB (🟡 +1.96 KB) 1.06 MB
/transactions/queue 49.37 KB (🟡 +1.97 KB) 1.05 MB
/transactions/tx 48.73 KB (🟡 +1.96 KB) 1.05 MB
/welcome/accounts 409 B (🟡 +2 B) 1 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jan 7, 2025

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements
74.11% (+0.01% 🔼)
14578/19670
🔴 Branches
51.7% (+0.01% 🔼)
3478/6727
🔴 Functions 57.12% 2065/3615
🟡 Lines
75.66% (+0.01% 🔼)
13224/17479

Test suite run success

1758 tests passing in 238 suites.

Report generated by 🧪jest coverage report action from 71721cd

@tmjssz
Copy link
Collaborator

tmjssz commented Jan 7, 2025

Looks good to me.
Perhaps we could also use the new OnlyOwner component in other places that are connected to the proposer logic? e.g. UpsertProposer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proposer button is enabled for nested safe signers
2 participants