Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade from vitest 2.1.8 to vitest 3.0.2 #5144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cardoso
Copy link
Contributor

@cardoso cardoso commented Jan 19, 2025

Details

Vitest 3.0 Blog Post
Changelogs: v3.0.0, v3.0.1, v3.0.2

There are a lot of nice things we can make use of to improve our test utils, remove workarounds, speed up CI, etc. As a bonus, vitest-dev/vitest#6975 and other @vitest/browser improvements addresses many issues that prevented #4594 .

I also updated rollup since there's a bug fix that in theory shouldn't but might affect vitest (through vite). I'll probably undo this to keep it bisect-friendly.

A small number of snapshots had a trailing newline while all other snapshots in the same suites didn't. Vitest 2 didn't consider those a mismatch. Vitest 3 does, which is a bug fix: vitest-dev/vitest#6107 (vitest-dev/vitest#7156) .

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

@cardoso cardoso requested a review from a team as a code owner January 19, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshots modify input by unexpectedly trimming and adjusting indentation
1 participant