Add support for passing new Spring Boot JarLauncher class #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @hjellek to sign the Salesforce Inc. Contributor License Agreement. |
|
I have signed the CLA now |
plaird
reviewed
Jan 12, 2024
springboot/springboot.bzl
Outdated
| @@ -385,6 +385,7 @@ def springboot( | |||
| name, | |||
| java_library, | |||
| boot_app_class, | |||
| spring_boot_launcher_class = "org.springframework.boot.loader.JarLauncher", | |||
There was a problem hiding this comment.
nitpick: for consistency, can you rename attr to boot_launcher_class
plaird
requested changes
Jan 12, 2024
plaird
approved these changes
Jan 15, 2024
|
I am preparing release 2.3.1 with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #177
Works in our project, and has backward compatability.
Open to suggestions for improvements!