Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies (esp. google.zxing) #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

moddx
Copy link

@moddx moddx commented Jun 23, 2022

Updated dependencies because of a vulnerability of a transient dependency (google.zxing -> com.beust:jcommander:1.72)

  • changed filehandling in ZxingPngQrGeneratorTest to work cross platform
  • enabled strict-mode for Base32-Decoder (new with commons-codec 1.15; uses lenient-mode by default, ie discard remaining bytes)

- changed filehandling in ZxingPngQrGeneratorTest to work cross platform
- enabled strict mode for Base32-Decoder (new with commons-codec 1.15, uses lenient by default, ie discard remaining bytes)
@@ -1,10 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>dev.samstevens.totp</groupId>
<groupId>com.github.moddx.totp</groupId>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not change this? Seems that @samdjstevens isn't looking at this library anymore though, we'd like an update of dependencies too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants