sample PR #122
sample PR #122
Conversation
jkbonfield
force-pushed
the
windows-actions-tmp-PR
branch
2 times, most recently
from
3ed5024 to
c79c40f
Compare
.github/workflows/unix-build.yml
Outdated
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Mac install dependencies | ||
| if: ${{ matrix.os == 'macos-latest' }} |
There was a problem hiding this comment.
I'd suggest runner.os instead. Its value is fixed, whereas next month you might want the matrix entry to be macos-14 or so.
| if: ${{ matrix.os == 'macos-latest' }} | |
| if: runner.os == 'macOS' |
(IIRC == is case insensitive anyway, but might as well use the documented capitalisation.)
There was a problem hiding this comment.
Thanks. At the moment this is very exploratory. Partly an attempt to avoid AppVeyor as it's getting slower and slower to launch Windows MinGW builds, and partly to offload some of the workload with give to cirrus-ci as it has a maximum amount of CPU we can use, has a reduced number of concurrent jobs, and we're low on priority in the free tier. (Or we get our bill payers to consider such tooling as something to pay for instead of just the usual corporate-ware.)
Current wrestle: submodules and gitattributes. Shrug. Should work! Will beat it around the head some more :)
jkbonfield
force-pushed
the
windows-actions-tmp-PR
branch
from
c79c40f to
35c5eb8
Compare
test of PR against a branch in samtools/htscodecs that already has a functioning GitHub Actions config.