-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: Support Python 3.13 #161
Conversation
Reviewer's Guide by SourceryThis PR adds Python 3.13 support by updating configuration files and documentation. The changes are straightforward, only requiring the addition of "3.13" to various files that specify Python version support. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmgate - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please verify compatibility with Python 3.13 alpha through testing before adding it to the supported versions. While the configuration changes are correct, we should ensure the codebase actually works with 3.13 first.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 180 180
Branches 15 15
=========================================
Hits 180 180 ☔ View full report in Codecov by Sentry. |
Type: Task
Description
Update the project config, CI, and docs to indicate support for Python 3.13.
Related Issues/PRs
Closes #157.
Summary by Sourcery
Add support for Python 3.13 by updating project configuration, CI workflows, and documentation.
Build:
CI:
Documentation: