-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stringify paths to unique paths correctly #83
base: master
Are you sure you want to change the base?
Conversation
lib/sassc/rails/importer.rb
Outdated
@@ -94,7 +94,9 @@ def imports(path, parent_path) | |||
return glob_imports(base, m[2], parent_path) | |||
end | |||
|
|||
search_paths = ([parent_dir] + load_paths).uniq | |||
# Compass and other gems us their own special loaders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
us their own
=> use their own
Updated thanks @PikachuEXE |
But the build failed :S |
well 💩 I'll look at it |
It appears that sassc/sass has changed how line_comments show up relative to this test. It was reporting: I did fix it as is but I believe it would actually be better to change the test to check on the first path which seems to make more sense to me. Though that's up to you @PikachuEXE |
I know nothing about the test |
The problem here is that gems like compass-sass and bootstrap-sass will build their own Importer classes that aren't being properly uniqued. Also this resolves the issue outlined in sass#79
The problem here is that gems like compass-sass and bootstrap-sass will
build their own Importer classes that aren't being properly uniqued.
This will resolve #79