Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is my attempt at solving issue #94, improving number description #102

Closed
wants to merge 1 commit into from

Conversation

dshunter107
Copy link

This is my 3rd time fixing a bug, so please let me know how I did. The only number types found were 'd' and 'f'. When doing a search throughout the entire file, no number types of 'L' were found.

@saynotobugsorg
Copy link
Owner

Thanks for your efforts. Looks like you just changed the test case. This won't work as the current NumberDescription implementation will not append f nor d to the strings. You will have to adjust the NumberDescription class to make this work.

@saynotobugsorg
Copy link
Owner

A good starting point would be to change extends DescriptionCompositon to implements Description and implement the required methods in https://github.com/saynotobugsorg/confidence/blob/main/confidence-core/src/main/java/org/saynotobugs/confidence/description/NumberDescription.java#L27C6-L27C6

@dshunter107
Copy link
Author

Thanks, back to the drawing board. I will continue working on it.

@dshunter107
Copy link
Author

Hello. I am having serious problems with the project. none of the org.dmfs imports are working. In addition, many of the classes are not being resolved to a variable even though the other class is in the project.

@dshunter107
Copy link
Author

Hello. I am having serious problems with the project. none of the org.dmfs imports are working. In addition, many of the classes are not being resolved to a variable even though the other class is in the project.

I think I may have figured it out. It seems my Eclipse was not recognizing the subprojects. I think I had to run gradlew buildEnvironment. I'm not exactly sure what I did

@dmfs
Copy link
Collaborator

dmfs commented Aug 31, 2023

Ah, I didn't use Eclipse in ~7 years and I never tried to build a Gradle Project with it. I can only recommend Intellij. Works flawlessly for me.

@dmfs
Copy link
Collaborator

dmfs commented Jul 27, 2024

closed by #183

@dmfs dmfs closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants