-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement assessment pass description, closes 202 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
============================================
+ Coverage 96.33% 96.50% +0.16%
- Complexity 922 953 +31
============================================
Files 240 246 +6
Lines 2157 2231 +74
Branches 66 72 +6
============================================
+ Hits 2078 2153 +75
- Misses 68 69 +1
+ Partials 11 9 -2 ☔ View full report in Codecov by Sentry. |
dmfs
force-pushed
the
202-pass-description
branch
6 times, most recently
from
December 8, 2024 19:43
7e8302c
to
09bff63
Compare
dmfs
force-pushed
the
202-pass-description
branch
from
December 8, 2024 20:00
09bff63
to
4532a0d
Compare
saynotobugsorg
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change an
Assessment
always provides a description, also in the pass case. This is useful forQuality
s likenot
, which can give a better description now. Beforenot
could only return the actual value and the expectation of the delegateQuality
. Now it can return a description of the actual assessment, which often contains more useful information.To support development of pass descriptions, the
passes
Quality
now has a variant that takes a single value and the expected description.Also, all
Quality
s have been updated to return proper pass descriptions, although some need further improvements in future updates.