Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement assessment pass description, closes 202 #211

Merged
merged 14 commits into from
Dec 8, 2024
Merged

Conversation

dmfs
Copy link
Collaborator

@dmfs dmfs commented Dec 8, 2024

With this change an Assessment always provides a description, also in the pass case. This is useful for Qualitys like not, which can give a better description now. Before not could only return the actual value and the expectation of the delegate Quality. Now it can return a description of the actual assessment, which often contains more useful information.

To support development of pass descriptions, the passes Quality now has a variant that takes a single value and the expected description.

Also, all Qualitys have been updated to return proper pass descriptions, although some need further improvements in future updates.

dmfs added 9 commits November 30, 2024 11:44
upgrade test module to test for pass descirption
TODO: restore varargs ctor that does not test description

upgrade many classes with pass descriptions and test
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (95ba3e1) to head (69edbc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #211      +/-   ##
============================================
+ Coverage     96.33%   96.50%   +0.16%     
- Complexity      922      953      +31     
============================================
  Files           240      246       +6     
  Lines          2157     2231      +74     
  Branches         66       72       +6     
============================================
+ Hits           2078     2153      +75     
- Misses           68       69       +1     
+ Partials         11        9       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmfs dmfs force-pushed the 202-pass-description branch 6 times, most recently from 7e8302c to 09bff63 Compare December 8, 2024 19:43
@dmfs dmfs force-pushed the 202-pass-description branch from 09bff63 to 4532a0d Compare December 8, 2024 20:00
@dmfs dmfs merged commit 0e76ee1 into main Dec 8, 2024
3 checks passed
@dmfs dmfs deleted the 202-pass-description branch December 8, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants