Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt setting. enforce new wildcard syntax #1668

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Jan 11, 2025

fix Scala 3 warnings

[warn] -- Warning: /home/runner/work/sbt-native-packager/sbt-native-packager/src/main/scala/com/typesafe/sbt/PackagerPlugin.scala:100:38 
[warn] 100 |    def java_application: Seq[Setting[_]] =
[warn]     |                                      ^
[warn]     |`_` is deprecated for wildcard arguments of types: use `?` instead
[warn]     |This construct can be rewritten automatically under -rewrite -source 3.4-migration.
[warn] -- Warning: /home/runner/work/sbt-native-packager/sbt-native-packager/src/main/scala/com/typesafe/sbt/PackagerPlugin.scala:116:33 
[warn] 116 |    def java_server: Seq[Setting[_]] =
[warn]     |                                 ^
[warn]     |`_` is deprecated for wildcard arguments of types: use `?` instead
[warn]     |This construct can be rewritten automatically under -rewrite -source 3.4-migration.

@@ -1,7 +1,7 @@
package com.typesafe.sbt.packager

import java.io.File
import java.nio.file.{Path => NioPath}
import java.nio.file.Path as NioPath

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't runner.dialectOverride.allowAsForImportRename = false prevent this ?

@xuwei-k xuwei-k marked this pull request as ready for review January 11, 2025 11:38
@muuki88 muuki88 added the maintenance release drafter category label Jan 11, 2025
@muuki88 muuki88 merged commit 379b670 into sbt:main Jan 11, 2025
15 checks passed
@xuwei-k xuwei-k deleted the wildcard-scalafmt branch January 11, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance release drafter category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants