fix: handle optional messages in networkActivity reducer and update t…

…est case for ReauthDialog
scality · Jan 16, 2025 · 673b122 · 673b122
1 parent 6f112ba
commit 673b122
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/react/reducers/networkActivity.ts b/src/react/reducers/networkActivity.ts
@@ -17,7 +17,7 @@ export default function networkActivity(
       return {
         ...state,
         counter: Math.max(state.counter - 1, 0),
-        messages: state.messages.shift(),
+        messages: state.messages?.shift(),
       };
 
     case 'NETWORK_AUTH_FAILURE':

diff --git a/src/react/ui-elements/__tests__/ReauthDialog.test.tsx b/src/react/ui-elements/__tests__/ReauthDialog.test.tsx
@@ -19,7 +19,7 @@ describe('class <ReauthDialog />', () => {
     });
     expect(screen.queryByText(modalTitle)).not.toBeInTheDocument();
   });
-  it.only('should not render the ReauthDialog component if the network activity authFailure is false even if error is of type byAuth', () => {
+  it('should not render the ReauthDialog component if the network activity authFailure is false even if error is of type byAuth', () => {
     renderWithRouterMatch(<ReauthDialog />, undefined, {
       networkActivity: {
         authFailure: false,
@@ -86,6 +86,7 @@ describe('class <ReauthDialog />', () => {
         },
       },
     });
+
     expect(screen.getByText(modalTitle)).toBeInTheDocument();
     expect(screen.getByText(defaultMessage)).toBeInTheDocument();
   });