-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZKUI-404: improve the error message while deleting an account with buckets #652
ZKUI-404: improve the error message while deleting an account with buckets #652
Conversation
ChengYanJin
commented
Oct 23, 2023
•
edited
Loading
edited
Hello chengyanjin,My role is to assist you with the merge of this Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
Codecov Report
@@ Coverage Diff @@
## development/2.1 #652 +/- ##
===================================================
+ Coverage 58.18% 58.22% +0.04%
===================================================
Files 208 208
Lines 10157 10162 +5
Branches 2942 2944 +2
===================================================
+ Hits 5910 5917 +7
+ Misses 4231 4229 -2
Partials 16 16
|
3410977
to
fd11797
Compare
expect( | ||
screen.getByText( | ||
/Unable to delete the account due to the presence of associated resources./i, | ||
), | ||
).toBeInTheDocument(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we ensure the text to be within the modal ?
expect( | |
screen.getByText( | |
/Unable to delete the account due to the presence of associated resources./i, | |
), | |
).toBeInTheDocument(); | |
expect( | |
within(screen.getByRole('dialog', { name: /Confirmation/i })).getByText( | |
/Unable to delete the account due to the presence of associated resources./i, | |
), | |
).toBeInTheDocument(); |
5bcf470
to
f494243
Compare
f494243
to
0f69c3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
Queue out of orderThe changeset has received all authorizations to enter the merge queue, Look into https://devdocs.scality.net/support/faq/#bert-e for guidance about The following options are set: approve |
/status |
StatusStatus report is not available. The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZKUI-404. Goodbye chengyanjin. |