Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-389: Init the Veeam configuration form UI #665

Merged

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Oct 31, 2023

Veeam 12
image

Veeam 11
image

@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2023

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-389 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.2.0

Please check the Fix Version/s of ZKUI-389, or the target
branch of this pull request.

@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-389-implement-veeam-configuration-ui branch from a4fc239 to 246396b Compare October 31, 2023 14:35
@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (development/2.2@758147e). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             development/2.2     #665   +/-   ##
==================================================
  Coverage                   ?   58.23%           
==================================================
  Files                      ?      209           
  Lines                      ?    10205           
  Branches                   ?     2956           
==================================================
  Hits                       ?     5943           
  Misses                     ?     4246           
  Partials                   ?       16           

@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-389-implement-veeam-configuration-ui branch 2 times, most recently from afdc816 to cb9e5e3 Compare November 6, 2023 12:49
@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-389-implement-veeam-configuration-ui branch from cb9e5e3 to 81ee9ce Compare November 6, 2023 13:48
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-389-implement-veeam-configuration-ui branch from 81ee9ce to 1a0f282 Compare November 6, 2023 13:56
@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

Please check the status of the associated issue ZKUI-389.

Goodbye chengyanjin.

@bert-e bert-e merged commit 1a0f282 into development/2.2 Nov 6, 2023
15 checks passed
@bert-e bert-e deleted the feature/ZKUI-389-implement-veeam-configuration-ui branch November 6, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants