Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-396 // Veeam Configuration Summary Page #669

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

hervedombya
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-396 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.2.0

Please check the Fix Version/s of ZKUI-396, or the target
branch of this pull request.

@hervedombya hervedombya force-pushed the feature/ZKUI-396-implement-veeam-summary-page branch 2 times, most recently from 5e99185 to 2105e8c Compare November 10, 2023 17:27
Update Veeam UI elements and package dependencies

Update dependencies and fix minor code issues

Add Veeam constants and update Veeam configuration
UI
@hervedombya hervedombya force-pushed the feature/ZKUI-396-implement-veeam-summary-page branch from 2105e8c to 242a280 Compare November 10, 2023 17:28
@bert-e
Copy link
Contributor

bert-e commented Nov 10, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

/>
</Stack>
</Wrap>
<Form
Copy link
Contributor

@ChengYanJin ChengYanJin Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to place the table not within a form.

@bert-e
Copy link
Contributor

bert-e commented Nov 13, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Attached the Stepper context to the window to make sure we reuse the same context even though the bundle load again
@codecov-commenter
Copy link

Codecov Report

Merging #669 (af6bb53) into development/2.2 (6b54d20) will decrease coverage by 0.15%.
The diff coverage is 42.10%.

❗ Current head af6bb53 differs from pull request most recent head 664a0d0. Consider uploading reports for the commit 664a0d0 to get more accurate results

@@                 Coverage Diff                 @@
##           development/2.2     #669      +/-   ##
===================================================
- Coverage            58.29%   58.14%   -0.15%     
===================================================
  Files                  211      214       +3     
  Lines                10263    10267       +4     
  Branches              2966     2965       -1     
===================================================
- Hits                  5983     5970      -13     
- Misses                4263     4280      +17     
  Partials                17       17              
Files Coverage Δ
src/react/ui-elements/Veeam/VeeamConstants.ts 100.00% <100.00%> (ø)
src/react/ui-elements/Veeam/useMockData.ts 62.50% <ø> (ø)
src/react/ui-elements/Veeam/VeeamConfiguration.tsx 78.26% <50.00%> (+0.48%) ⬆️
src/react/ui-elements/Veeam/VeeamSteps.tsx 33.33% <33.33%> (ø)
src/react/ui-elements/Veeam/VeeamSummary.tsx 20.00% <20.00%> (ø)
src/react/ui-elements/Veeam/VeeamTable.tsx 60.00% <33.33%> (-0.53%) ⬇️

... and 3 files with indirect coverage changes

@bert-e
Copy link
Contributor

bert-e commented Nov 13, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@scality scality deleted a comment from bert-e Nov 13, 2023
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@hervedombya
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 14, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 14, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

Please check the status of the associated issue ZKUI-396.

Goodbye hervedombya.

@bert-e bert-e merged commit 664a0d0 into development/2.2 Nov 14, 2023
14 of 15 checks passed
@bert-e bert-e deleted the feature/ZKUI-396-implement-veeam-summary-page branch November 14, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants