[ENH] Add resample nb points + dps #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @arnaudbore, Thank you for updating !
Comment last updated at 2024-09-27 16:09:03 UTC |
arnaudbore
changed the title
EmmaRenauld
reviewed
Sep 26, 2024
EmmaRenauld
reviewed
Sep 26, 2024
EmmaRenauld
approved these changes
Sep 26, 2024
EmmaRenauld
reviewed
Sep 26, 2024
dwi_ml/data/hdf5/hdf5_creation.py
Outdated
| @@ -641,11 +675,10 @@ def _process_one_streamline_group( | |||
| The Euclidean length of each streamline | |||
| """ | |||
| tractograms = self.groups_config[group]['files'] | |||
|
|
|||
| if self.step_size and self.compress: | |||
| raise ValueError( | |||
There was a problem hiding this comment.
nb_points is not checked. But now, you check that in the __init__, so we can remove the check here.
| 'kept.') | ||
|
|
||
| for dps_key in self.dps_keys: | ||
| logging.debug(" Include dps \"{}\" in the HDF5.".format(dps_key)) |
There was a problem hiding this comment.
Maybe a check that the dps_key exists in the tractogram? Else, error, or else, warning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add resampling with nb points and skip check header compatible when only tractograms.
Have you